Set HTTP status codes when declining payload

This commit is contained in:
Thorben Günther 2022-10-10 22:59:05 +02:00
parent a6c41b2aac
commit 9435feba8d
No known key found for this signature in database
GPG key ID: 415CD778D8C5AFED

View file

@ -37,12 +37,14 @@ func (rcv *receiver) handleWebhooks(w http.ResponseWriter, r *http.Request) {
defer r.Body.Close() defer r.Body.Close()
if r.Method != http.MethodPost { if r.Method != http.MethodPost {
http.Error(w, "Only POST allowed", http.StatusMethodNotAllowed)
rcv.logger.Debugf("illegal HTTP method: expected %q, got %q", "POST", r.Method) rcv.logger.Debugf("illegal HTTP method: expected %q, got %q", "POST", r.Method)
return return
} }
contentType := r.Header.Get("Content-Type") contentType := r.Header.Get("Content-Type")
if contentType != "application/json" { if contentType != "application/json" {
http.Error(w, "Only application/json allowed", http.StatusUnsupportedMediaType)
rcv.logger.Debugf("illegal content type: %s", contentType) rcv.logger.Debugf("illegal content type: %s", contentType)
return return
} }
@ -117,6 +119,7 @@ func (rcv *receiver) basicAuthMiddleware(handler http.HandlerFunc) http.HandlerF
} }
if user != rcv.cfg.User || pass != rcv.cfg.Password { if user != rcv.cfg.User || pass != rcv.cfg.Password {
http.Error(w, "Unauthorized", http.StatusUnauthorized)
rcv.logger.Debug("basic auth: wrong user or password") rcv.logger.Debug("basic auth: wrong user or password")
return return
} }