simono41/phanpy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix logic for cached statuses

Browse source
This commit is contained in:
Lim Chee Aun 2022-12-23 11:28:25 +08:00
parent 31e2196cd6
commit d3e3e47527
1 changed files with 14 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/pages/status.jsx
View file

@ -46,24 +46,23 @@ function StatusPage({ id }) {
useEffect(() => { useEffect(() => {
setUIState('loading'); setUIState('loading');
const containsStatus = statuses.find((s) => s.id === id); const cachedStatuses = store.session.getJSON('statuses-' + id);
if (!containsStatus) { if (cachedStatuses) {
// Case 1: On first load, or when navigating to a status that's not cached at all // Case 1: It's cached, let's restore them to make it snappy
setStatuses([{ id }]); const reallyCachedStatuses = cachedStatuses.filter(
(s) => states.statuses.has(s.id),
// Some are not cached in the global state, so we need to filter them out
);
setStatuses(reallyCachedStatuses);
} else { } else {
const cachedStatuses = store.session.getJSON('statuses-' + id); const heroIndex = statuses.findIndex((s) => s.id === id);
if (cachedStatuses) { if (heroIndex !== -1) {
// Case 2: Looks like we've cached this status before, let's restore them to make it snappy // Case 2: It's in current statuses. Slice off all descendant statuses after the hero status to be safe
const reallyCachedStatuses = cachedStatuses.filter(
(s) => snapStates.statuses.has(s.id),
// Some are not cached in the global state, so we need to filter them out
);
setStatuses(reallyCachedStatuses);
} else {
// Case 3: Unknown state, could be a sub-comment. Let's slice off all descendant statuses after the hero status to be safe because they are custom-rendered with sub-comments etc
const heroIndex = statuses.findIndex((s) => s.id === id);
const slicedStatuses = statuses.slice(0, heroIndex + 1); const slicedStatuses = statuses.slice(0, heroIndex + 1);
setStatuses(slicedStatuses); setStatuses(slicedStatuses);
} else {
// Case 3: Not cached and not in statuses, let's start from scratch
setStatuses([{ id }]);
} }
} }