2020-03-20 11:50:20 +01:00
|
|
|
<!--
|
|
|
|
|
You are amazing!
|
|
|
|
|
Thanks for contributing to our project <3
|
|
|
|
|
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
|
|
|
|
|
-->
|
|
|
|
|
## Breaking change
|
|
|
|
|
<!--
|
|
|
|
|
If your PR contains a breaking change for existing users, it is important
|
|
|
|
|
to tell them what breaks, how to make it work again and why we did this.
|
|
|
|
|
This piece of text is published with the release notes, so it helps if you
|
|
|
|
|
write it towards our users, not us.
|
|
|
|
|
Note: Remove this section if this PR is NOT a breaking change.
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
## Proposed change
|
|
|
|
|
<!--
|
|
|
|
|
Describe the big picture of your changes here to communicate to the
|
|
|
|
|
maintainers why we should accept this pull request. If it fixes a bug
|
|
|
|
|
or resolves a feature request, be sure to link to that issue in the
|
|
|
|
|
additional information section.
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
## Type of change
|
|
|
|
|
<!--
|
|
|
|
|
What type of change does your PR introduce to pyiCloud?
|
|
|
|
|
NOTE: Please, check only 1 box! (with an `x`)
|
|
|
|
|
If your PR requires multiple boxes to be checked, you'll most likely need to
|
|
|
|
|
split it into multiple PRs. This makes things easier and faster to code review.
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
- [ ] Dependency upgrade
|
|
|
|
|
- [ ] Bugfix (non-breaking change which fixes an issue)
|
|
|
|
|
- [ ] New service (thank you!)
|
|
|
|
|
- [ ] New feature (which adds functionality to an existing service)
|
|
|
|
|
- [ ] Breaking change (fix/feature causing existing functionality to break)
|
|
|
|
|
- [ ] Code quality improvements to existing code or addition of tests
|
2020-03-21 14:49:32 +01:00
|
|
|
- [ ] Documentation or code sample
|
2020-03-20 11:50:20 +01:00
|
|
|
|
|
|
|
|
## Example of code:
|
|
|
|
|
<!--
|
|
|
|
|
Supplying a code snippet, makes it easier for a maintainer to test your PR.
|
|
|
|
|
Furthermore, for new services, it gives an impression of how we should use it.
|
|
|
|
|
Note: Remove this section for a dependency upgrade, a bugfix or code quality/test PR.
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
```python
|
|
|
|
|
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
## Additional information
|
|
|
|
|
<!--
|
|
|
|
|
Details are important, and help maintainers processing your PR.
|
|
|
|
|
Please be sure to fill out additional details, if applicable.
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
- This PR fixes or closes issue: fixes #
|
|
|
|
|
- This PR is related to issue:
|
|
|
|
|
|
|
|
|
|
## Checklist
|
|
|
|
|
<!--
|
|
|
|
|
Put an `x` in the boxes that apply. You can also fill these out after
|
|
|
|
|
creating the PR. If you're unsure about any of them, don't hesitate to ask.
|
|
|
|
|
We're here to help! This is simply a reminder of what we are going to look
|
|
|
|
|
for before merging your code.
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
- [ ] The code change is tested and works locally.
|
|
|
|
|
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
|
|
|
|
|
- [ ] There is no commented out code in this PR.
|
|
|
|
|
- [ ] Tests have been added to verify that the new code works.
|
|
|
|
|
|
|
|
|
|
If user exposed functionality or configuration variables are added/changed:
|
|
|
|
|
|
|
|
|
|
- [ ] Documentation added/updated to README
|
