Commit graph

258 commits

Author SHA1 Message Date
Nicholas Charriere
c22c902de6 Merge pull request #23 from pinterest/more-env-vars
Add ENV variables options
2016-09-08 09:58:01 -07:00
Nicholas Charriere
89eef898e4 Merge pull request #24 from voidpirate/master
Catch Connection Error when redis isn't up #22
2016-08-28 07:27:29 -07:00
Nicholas Charriere
2e8d45e691 Merge pull request #27 from samueldg/improve-dev-setup
Improve development setup
2016-08-28 07:17:34 -07:00
Brandon Davis
fadd2854e5 Fix for remaining comments.
- Call function within try/catch
- Syntax clean up
2016-08-22 21:59:08 -07:00
Brandon Davis
f0c9f6a09d Merge remote-tracking branch 'upstream/master' 2016-08-22 21:18:08 -07:00
Samuel Dion-Girardeau
0d76a62427 Fix coverage commands
- Remove setup.py, as the tests don't run it;
- Put the correct test command;
- Add `$ ` prompts, for conformity with the previous steps.
2016-08-22 20:32:22 -04:00
Samuel Dion-Girardeau
9177f0fab0 Fix flake8 command in development flow
- Missing setup.py, and wrong path for tests
- Removed extra new lines that was causing a warning
2016-08-22 20:32:22 -04:00
Samuel Dion-Girardeau
ae9bebb365 Add debug server steps to development flow 2016-08-22 20:32:22 -04:00
Samuel Dion-Girardeau
a8401434cb Bump flask to 0.11.1
One of the main advantages is the easy debug mode,
with autoreload capabilities.

Several other fixes & features:
http://flask.pocoo.org/docs/0.11/changelog/#version-0-11
2016-08-22 20:32:22 -04:00
Samuel Dion-Girardeau
56b0414524 Explicitly list dev requirements in dedicated file
Pinning the versions to the latest stable at current time.
2016-08-22 20:32:22 -04:00
Jon Parise
09ca4b6709 Merge pull request #26 from samueldg/fix/jquery_path
Fix jquery static lib path
2016-08-22 16:41:14 -07:00
Samuel Dion-Girardeau
2af4117ecb Fix jquery static lib path 2016-08-22 19:03:31 -04:00
Brandon Davis
e0ae801b24 Remove TimeoutError import 2016-08-21 21:33:12 -07:00
Brandon Davis
9694d7da7f Switch to use decorator for checking if redis server is up.
- setup.py removed empty line flake8 was complaining.
2016-08-21 21:27:00 -07:00
Brandon Davis
c9db491485 Minor cleanup 2016-08-21 11:50:06 -07:00
Brandon Davis
2d6aec17cd Remove unused traceback and code formatting cleanup 2016-08-21 11:24:20 -07:00
Brandon Davis
4feeaef2fd Add exception handling for when redis is down and or not running. 2016-08-21 11:20:00 -07:00
Nicholas Charriere
2855e5b9b6 Add env var options 2016-08-21 09:05:01 +02:00
Nicholas Charriere
67bbb6f220 Merge pull request #21 from samueldg/feature/copy_to_clipboard
Add button to copy link/password to clipboard
2016-08-21 08:59:10 +02:00
Samuel Dion-Girardeau
d0f8505bc4 Stop serving jquery from CDN 2016-08-20 16:06:01 -04:00
Samuel Dion-Girardeau
bbc01041da Stop serving clipboard from CDN 2016-08-20 15:55:36 -04:00
Samuel Dion-Girardeau
9b65550b71 Merge remote-tracking branch 'origin/master' into feature/copy_to_clipboard 2016-08-20 15:48:11 -04:00
Samuel Dion-Girardeau
26972a2f52 Move snappass-specific js/css into separate dir 2016-08-20 15:47:18 -04:00
Nicholas Charriere
64b5c3f7be Merge pull request #19 from samueldg/feature/tox_python3_support
feature/tox_python3_support
2016-08-15 13:52:32 -07:00
Samuel Dion-Girardeau
073885d651 Add button to copy link/password to clipboard
- Using clipboard.js
- On browsers not supporting evalCommand(), the text will be selected,
  and the keyboard shortcut displayed, depending on platform.
  (tested on Safari)
- Now using Bootstrap readonly text form, instead of a header,
  to display the passwords and generated links;
- Using fontawesome to get a clipboard icon (like GitHub, GitLab, etc.)
- fontawesome and clipboard.js are pulled from a CDN.
2016-08-13 20:14:36 -04:00
Samuel Dion-Girardeau
00f6964a90 Fix python2.6 support for tests
- "{}".format('foo') does not work on python2.6, as the index needs to be explicitly specified.
- assertIn(x, y) was only introduced in 2.7, reverting to assertTrue(x in y)

Updated test environments definitions and docs accordingly.
2016-08-12 18:47:02 -04:00
Yongwen Xu
c0d1e0ae39 Merge pull request #18 from samueldg/enhancement/no_autocompletion
Prevent browser autocompletion of password
2016-08-11 23:52:31 -07:00
Yongwen Xu
1ab2f6ee66 Merge pull request #20 from futureimperfect/typo-fix
Fixed minor typos.
2016-08-11 23:47:42 -07:00
James Barclay
b9e34ce2f8 Fixed minor typos. 2016-08-12 00:26:22 -04:00
Samuel Dion-Girardeau
20635bdec8 Explicitly define all supported python environment
With only 3.5, travis-ci works, because 2.7, 3.3 and 3.4 interpreters
are present by default,  but it might break randomly at some point.

Definining all the versions explicitly, and using the tox-travis plugin
is more robust.

Also, 2.6 was removed from the "officially supported" python versions,
as the tests are not run (and don't pass).
2016-08-11 22:48:36 -04:00
Samuel Dion-Girardeau
faef96c30c Use python 3.5 in the Docker image
Since tests are running for 3.5, there is no
point in not using the latest & greatest version.
2016-08-11 22:33:17 -04:00
Samuel Dion-Girardeau
28e19b51a7 Add support for python 3.3 in tox
And update associated documentation
2016-08-11 22:33:17 -04:00
Samuel Dion-Girardeau
a46fc40aa3 Improve string encoding for password retrieval
- Prevent the password from displaying as b'...' in the app;
 - Use Flask's `get_data(as_test=True)` to read the data, in the tests;
 - Add test to ensure `get_password` is not returning bytes.
2016-08-11 22:05:35 -04:00
Samuel Dion-Girardeau
c0ec6dbec2 Remove useless top-level __init__ file
If the top-level snappass directory is a package,
`import` will fail, depending on the environment,
python version, etc.
2016-08-11 22:05:35 -04:00
Samuel Dion-Girardeau
3159c3e230 Prevent browser autocompletion of password
Using the `autocomplete="off" attribute
2016-08-11 20:44:18 -04:00
Carlos Moreno
b7edf6401d Merge pull request #1 from pinterest/master
updating fork
2016-08-09 11:18:37 -06:00
Nicholas Charriere
a3f1ddef62 Merge pull request #15 from pinterest/new-travis-container-infrastructure
Upgrade to new container travis infrastructure
2016-07-20 20:46:14 -07:00
Nicholas Charriere
bbfb48576f Upgrade to new container travis infrastructure 2016-07-20 20:39:53 -07:00
Yongwen Xu
918ed8bf02 Merge pull request #14 from pinterest/yongwen-patch-2
more info on Docker
2016-07-19 14:39:11 -07:00
Nicholas Charriere
653e93080c Merge pull request #12 from pinterest/tweaks
Improve wording
2016-07-19 04:05:23 +00:00
Yongwen Xu
938b31fc2c more info on Docker
fixed docker link, added docker compose and start up info.
2016-07-18 17:41:34 -07:00
Nicholas Charriere
479dca09b2 Improve wording 2016-07-18 17:14:38 -07:00
Yongwen Xu
8360cf4498 Merge pull request #8 from samueldg/feature/dockerized_app
looks good. agree that the redis is better separated from snappass's dockerfile. Thanks for the dockerizing snappass.
2016-07-18 15:39:02 -07:00
Samuel Dion-Girardeau
98c3ffe3e5 Document Docker setup steps 2016-07-18 17:37:54 -04:00
Samuel Dion-Girardeau
fb020522ad Add compose file for easy setup 2016-07-18 17:37:54 -04:00
Samuel Dion-Girardeau
b34b5c4b69 Add Dockerfile/.dockerignore files 2016-07-18 17:37:54 -04:00
Samuel Dion-Girardeau
6c3f8f6884 Ensure the egg is a directory, not a zip
Prevents NotADirectoryError's in flask templates

Ref.:
https://github.com/pallets/flask/issues/1562
https://github.com/pallets/flask/issues/1645
2016-07-18 17:37:54 -04:00
Nicholas Charriere
64755bae8a Merge pull request #11 from pinterest/tweaks
Cleanup gitignore and make linter pass
2016-07-18 20:53:38 +00:00
Nicholas Charriere
a9fc727240 Fix tests 2016-07-18 13:36:06 -07:00
Nicholas Charriere
d88cf2600e Refactor _id() function to be inline 2016-07-18 13:35:57 -07:00