adjust error message for when mobile confirmation fails (#311)

- adjust error message for when mobile confirmation fails
- update issue template
This commit is contained in:
Carson McManus 2023-09-04 13:10:30 -04:00 committed by GitHub
parent f2821d2837
commit 29aca56067
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions

View file

@ -10,7 +10,7 @@ body:
id: version
attributes:
label: Version
description: What version of steamguard-cli are you running? You can find this by running `steamguard --version`.
description: What version of steamguard-cli are you running? You can find this by running `steamguard --version`. **Do NOT just say "latest", or your issue will be automatically closed.**
validations:
required: true
- type: textarea

View file

@ -109,7 +109,7 @@ where
return Err(ConfirmerError::InvalidTokens);
}
if !body.success {
return Err(anyhow!("Server responded with failure.").into());
return Err(ConfirmerError::RemoteFailure);
}
Ok(body.conf)
}
@ -162,7 +162,7 @@ where
return Err(ConfirmerError::InvalidTokens);
}
if !body.success {
return Err(anyhow!("Server responded with failure.").into());
return Err(ConfirmerError::RemoteFailure);
}
Ok(())
@ -237,7 +237,7 @@ where
return Err(ConfirmerError::InvalidTokens);
}
if !body.success {
return Err(anyhow!("Server responded with failure.").into());
return Err(ConfirmerError::RemoteFailure);
}
Ok(())
@ -316,6 +316,8 @@ pub enum ConfirmerError {
NetworkFailure(#[from] reqwest::Error),
#[error("Failed to deserialize response: {0}")]
DeserializeError(#[from] serde_path_to_error::Error<serde_json::Error>),
#[error("Remote failure: Valve's server responded with a failure. This is likely not a steamguard-cli bug, Steam's confirmation API is just unreliable. Wait a bit and try again.")]
RemoteFailure,
#[error("Unknown error: {0}")]
Unknown(#[from] anyhow::Error),
}