simono41/steamguard-cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

trade: misc confirmation fixes and tests (#246)

Browse source
This commit is contained in:
Carson McManus 2023-06-27 15:13:26 -04:00 committed by GitHub
parent 0d24d12c55
commit 6af4374da3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
steamguard/src/confirmation.rs
View file

@ -92,7 +92,7 @@ impl<'a> Confirmer<'a> {
let mut deser = serde_json::Deserializer::from_str(text.as_str());
let body: ConfirmationListResponse = serde_path_to_error::deserialize(&mut deser)?;
if body.needsauth.unwrap_or(false) {
if body.needauth.unwrap_or(false) {
return Err(ConfirmerError::InvalidTokens);
}
if !body.success {
@ -276,6 +276,7 @@ impl From<u32> for ConfirmationType {
1 => ConfirmationType::Generic,
2 => ConfirmationType::Trade,
3 => ConfirmationType::MarketSell,
5 => ConfirmationType::AccountDetails,
6 => ConfirmationType::AccountRecovery,
v => ConfirmationType::Unknown(v),
}
@ -286,7 +287,8 @@ impl From<u32> for ConfirmationType {
pub struct ConfirmationListResponse {
pub success: bool,
#[serde(default)]
pub needsauth: Option<bool>,
pub needauth: Option<bool>,
#[serde(default)]
pub conf: Vec<Confirmation>,
}
@ -347,6 +349,24 @@ mod tests {
Ok(())
}
#[test]
fn test_parse_confirmations_2() -> anyhow::Result<()> {
struct Test {
text: &'static str,
}
let cases = [Test {
text: include_str!("fixtures/confirmations/need-auth.json"),
}];
for case in cases.iter() {
let confirmations = serde_json::from_str::<ConfirmationListResponse>(case.text)?;
assert_eq!(confirmations.conf.len(), 0);
assert_eq!(confirmations.needauth, Some(true));
}
Ok(())
}
#[test]
fn test_generate_confirmation_hash_for_time() {
assert_eq!(

4
steamguard/src/fixtures/confirmations/need-auth.json Normal file
View file

@ -0,0 +1,4 @@
{
"success": false,
"needauth": true
}